suneet-s commented on pull request #10332: URL: https://github.com/apache/druid/pull/10332#issuecomment-683529929
@joykent99 Thanks for the contribution! I haven't looked through the approach yet, but I notice there aren't any integration tests added for this change. Can you add one for the bug reported in #7243. This way we can be sure not to break this feature going forward. I think you can do this by modifying one of the tests in `ITIndexerTest`. Consider adding a stringFirst and stringLast aggregation to `/indexer/wikipedia_index_task.json` and then modifying one of the queries in `/indexer/wikipedia_index_queries.json` to test that the aggregation is correct. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
