joykent99 commented on a change in pull request #10332:
URL: https://github.com/apache/druid/pull/10332#discussion_r482590046
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/first/StringFirstAggregatorFactory.java
##########
@@ -188,7 +188,7 @@ public Comparator getComparator()
@Override
public Object combine(Object lhs, Object rhs)
{
- return TIME_COMPARATOR.compare(lhs, rhs) > 0 ? lhs : rhs;
+ return TIME_COMPARATOR.compare(lhs, rhs) < 0 ? lhs : rhs;
Review comment:
Yes. The existing test case was testing the wrong behavior. The fix to
the test is also in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
