jihoonson commented on issue #8328: URL: https://github.com/apache/druid/issues/8328#issuecomment-684113167
Sorry, I was thinking to test out all those libraries we discussed here, but have never got to it. I quickly checked AutoValue, Immutables, and Lombok today, and it seems Lombok might suit our needs most because we often add more methods in the "value" classes which seems not possible in other libraries since they generate concrete classes based on the annotated interface (I quickly read the docs of them, so could be wrong). It might be arguable whether it's a good practice or not, but that's what we have now. Also, [I remember wrong about the line number changes and Lombok doesn't change the line number in stack trace](https://stackoverflow.com/questions/37908097/line-numbers-generation-with-lombok). My other concern was about potentially slow response of the IDE but I think it could apply same for other libraries as well. I would vote for trying it out and seeing if there is any other issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
