jihoonson opened a new pull request #10336:
URL: https://github.com/apache/druid/pull/10336
### Description
This PR has refactoring around handling `ParseExceptions` in ingestion, so
that we can easily support the same logic for parallel task as well. The
parseException can be thrown in 2 places on the ingestion side, i.e., when you
parse the input data based on input format (in `InputEntityReader`) and when
you convert the parsed object to a desired data type (in `IncrementalIndex`).
To handle the exceptions in a more structured way, I added
`ParseExceptionHandler` which handles all parseExceptions thrown on the
ingestion side.
`FilteringCloseableInputRowIterator` was added to handle common row filters.
It also has the parseExceptionHandler to handle parseExceptions thrown while
parsing input data. The same parseExceptionHandler instance is passed down to
`AppenderatorImpl` to handle parseExceptions thrown while converting parsed
objects.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `ParseExceptionHandler`
* `FilteringCloseableInputRowIterator`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
