joykent99 commented on a change in pull request #10332:
URL: https://github.com/apache/druid/pull/10332#discussion_r482597454



##########
File path: 
processing/src/test/java/org/apache/druid/query/aggregation/first/StringFirstAggregationTest.java
##########
@@ -115,7 +117,7 @@ public void testCombine()
   {
     SerializablePairLongString pair1 = new 
SerializablePairLongString(1467225000L, "AAAA");
     SerializablePairLongString pair2 = new 
SerializablePairLongString(1467240000L, "BBBB");
-    Assert.assertEquals(pair2, stringFirstAggFactory.combine(pair1, pair2));
+    Assert.assertEquals(pair1, stringFirstAggFactory.combine(pair1, pair2));

Review comment:
       This is the fix to the existing test for 
`StringFirstAggregatorFactory.combine()` fixes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to