suneet-s commented on pull request #10336:
URL: https://github.com/apache/druid/pull/10336#issuecomment-687199069
> ```
> 279 L rowIngestionMeters.incrementProcessed();
> 280 F | L | B(0/2) } else if (addResult.hasParseException()) {
> 281 L
parseExceptionHandler.handle(addResult.getParseException());
> 282 F }
> ```
>
> The test coverage bot is failing because of the missing tests for these
branches, but they are being covered by `IndexTaskTest` which is in
`indexing-service`.
Oops sorry about my previous comment. How did you get code coverage to show
you that these branches were covered? I tried running this locally, but it
doesn't show me code coverage. This is what I see in the `indexing modules`
tests
```
Diff coverage statistics:
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 100% (1/1) | 100% (0/0) | 100% (1/1) |
org/apache/druid/indexing/common/stats/DropwizardRowIngestionMeters.java
| 100% (6/6) | 100% (0/0) | 100% (7/7) |
org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentGenerateTask.java
| 100% (18/18) | 100% (4/4) | 100% (16/16) |
org/apache/druid/indexing/common/task/batch/parallel/PartialDimensionDistributionTask.java
| 80% (25/31) | 70% (7/10) | 93% (27/29) |
org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseSubTask.java
| 0% (0/45) | 0% (0/16) | 25% (2/8) |
org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
| 0% (0/1) | 100% (0/0) | 100% (1/1) |
org/apache/druid/indexing/seekablestream/SeekableStreamIndexTask.java
| 88% (15/17) | 66% (4/6) | 48% (12/25) |
org/apache/druid/indexing/seekablestream/StreamChunkParser.java
| 100% (14/14) | 100% (2/2) | 85% (24/28) |
org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
| 89% (17/19) | 75% (6/8) | 89% (33/37) |
org/apache/druid/indexing/common/task/InputSourceProcessor.java
| 100% (2/2) | 100% (0/0) | 100% (11/11) |
org/apache/druid/indexing/common/task/BatchAppenderators.java
| 90% (36/40) | 85% (12/14) | 83% (10/12) |
org/apache/druid/indexing/common/task/IndexTask.java
| 95% (21/22) | 90% (9/10) | 94% (51/54) |
org/apache/druid/indexing/common/task/FilteringCloseableInputRowIterator.java
| 80% (8/10) | 50% (1/2) | 80% (8/10) |
org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
| 100% (4/4) | 100% (0/0) | 0% (0/1) |
org/apache/druid/indexing/overlord/sampler/InputSourceSampler.java
------------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
