vogievetsky opened a new pull request #10360:
URL: https://github.com/apache/druid/pull/10360


   ### Description
   
   This PR at the heart creates a useQueryManager hook that lets allows us to 
convert a bunch of web console components to be functional instead of Component 
class based. This PR has some user visible changes and a bunch of refactoring 
work
   
   #### Big user visible changes
   
   Query cancelation in the query view
   
   
![cancel-query](https://user-images.githubusercontent.com/177816/92290443-efaa3280-eec8-11ea-8456-217be107107e.png)
   
   Better error reporting in the query view with link to where the error is in 
the code
   
   ![better error 
view](https://user-images.githubusercontent.com/177816/92290278-74e11780-eec8-11ea-99b7-3948002d055d.png)
   
   Replace `Auto query` to a smart `Live query` selector with new auto mode 
(re-run the query if the last one took < 10s)
   
   
![image](https://user-images.githubusercontent.com/177816/92290489-22ecc180-eec9-11ea-9f45-53be9c892476.png)
   
   
   #### Small user visible changes
   
   - The annoying tooltip on the `Run` button was removed - it did not work 
right and would stick open.
   - Added more keywords to the SQL highlighter
   
   #### Internal cleanup
   
   - Upgraded DruidQueryToolkit to support query cancelation
   - Updated `mkcomp` helper to generate shallow snapshot tests by default
   - Turn a bunch of components into functional components
   - Integrated `QueryState` to represent the state of the query in many 
components
   - Add `HighlightText` component to support the error view highlighting
   - Fix typos
   
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to