abhishekagarwal87 commented on a change in pull request #10350:
URL: https://github.com/apache/druid/pull/10350#discussion_r486103951



##########
File path: docs/querying/sql.md
##########
@@ -561,6 +561,8 @@ The [DataSketches 
extension](../development/extensions-core/datasketches-extensi
 |`COALESCE(value1, value2, ...)`|Returns the first value that is neither NULL 
nor empty string.|
 |`NVL(expr,expr-for-null)`|Returns 'expr-for-null' if 'expr' is null (or empty 
string for string type).|
 |`BLOOM_FILTER_TEST(<expr>, <serialized-filter>)`|Returns true if the value is 
contained in a Base64-serialized bloom filter. See the [Bloom filter 
extension](../development/extensions-core/bloom-filter.html) documentation for 
additional details.|
+|`CONTAINS_STR(<expr>, str)`|Returns true if the `str` is a substring of 
`expr`.|
+|`ICONTAINS_STR(<expr>, str)`|Returns true if the `str` is a substring of 
`expr`. The match is case-insensitive.|

Review comment:
       These are really good points and it's my bad to not put my reasonings in 
the description earlier.  The description has more details but in short, 
    - `contains` is a standard operator in calcite, built with non-string input 
types. 
    - The function names are different for case insensitive flavour, to not 
overload the function signature and follow standard MySQL convention 
(`like`/`ilike`) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to