abhishekagarwal87 commented on a change in pull request #10350:
URL: https://github.com/apache/druid/pull/10350#discussion_r486197897
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/expression/ExpressionsTest.java
##########
@@ -1072,6 +1075,108 @@ public void testPad()
);
}
+ @Test
+ public void testContains()
+ {
+ testHelper.testFilter(
+
ContainsOperatorConversion.createOperatorConversion(true).calciteOperator(),
+ ImmutableList.of(
+ testHelper.makeInputRef("spacey"),
+ testHelper.makeLiteral("there")
+ ),
+ Collections.emptyList(),
+ new SearchQueryDimFilter("spacey", new
ContainsSearchQuerySpec("there", true), null),
+ true
+ );
+
+ testHelper.testFilter(
+
ContainsOperatorConversion.createOperatorConversion(true).calciteOperator(),
+ ImmutableList.of(
+ testHelper.makeInputRef("spacey"),
+ testHelper.makeLiteral("There")
+ ),
+ Collections.emptyList(),
+ new SearchQueryDimFilter("spacey", new
ContainsSearchQuerySpec("There", true), null),
+ false
+ );
+
+ testHelper.testFilter(
+
ContainsOperatorConversion.createOperatorConversion(false).calciteOperator(),
+ ImmutableList.of(
+ testHelper.makeInputRef("spacey"),
+ testHelper.makeLiteral("There")
+ ),
+ Collections.emptyList(),
+ new SearchQueryDimFilter("spacey", new
ContainsSearchQuerySpec("There", false), null),
+ true
+ );
+
+ testHelper.testFilter(
+
ContainsOperatorConversion.createOperatorConversion(true).calciteOperator(),
+ ImmutableList.of(
+ testHelper.makeCall(
+ SqlStdOperatorTable.CONCAT,
+ testHelper.makeLiteral("what is"),
+ testHelper.makeInputRef("spacey")
+ ),
+ testHelper.makeLiteral("what")
+ ),
+ ImmutableList.of(
+ new ExpressionVirtualColumn(
+ "v0",
+ "concat('what is',\"spacey\")",
+ ValueType.STRING,
+ TestExprMacroTable.INSTANCE
+ )
+ ),
+ new SearchQueryDimFilter("v0", new ContainsSearchQuerySpec("what",
true), null),
+ true
+ );
+
+ testHelper.testFilter(
+
ContainsOperatorConversion.createOperatorConversion(true).calciteOperator(),
+ ImmutableList.of(
+ testHelper.makeCall(
+ SqlStdOperatorTable.CONCAT,
+ testHelper.makeLiteral("what is"),
+ testHelper.makeInputRef("spacey")
+ ),
+ testHelper.makeLiteral("there")
+ ),
+ ImmutableList.of(
+ new ExpressionVirtualColumn(
+ "v0",
+ "concat('what is',\"spacey\")",
+ ValueType.STRING,
+ TestExprMacroTable.INSTANCE
+ )
+ ),
+ new SearchQueryDimFilter("v0", new ContainsSearchQuerySpec("there",
true), null),
+ true
+ );
+
+ testHelper.testFilter(
+
ContainsOperatorConversion.createOperatorConversion(false).calciteOperator(),
+ ImmutableList.of(
+ testHelper.makeCall(
+ SqlStdOperatorTable.CONCAT,
+ testHelper.makeLiteral("what is"),
+ testHelper.makeInputRef("spacey")
+ ),
+ testHelper.makeLiteral("What")
+ ),
+ ImmutableList.of(
+ new ExpressionVirtualColumn(
+ "v0",
+ "concat('what is',\"spacey\")",
+ ValueType.STRING,
+ TestExprMacroTable.INSTANCE
+ )
+ ),
+ new SearchQueryDimFilter("v0", new ContainsSearchQuerySpec("What",
false), null),
+ true
+ );
+ }
Review comment:
I have not added native functions for these methods. Yet. similar
discussion - https://github.com/apache/druid/pull/10350/files#r486068975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
