clintropolis commented on pull request #10370: URL: https://github.com/apache/druid/pull/10370#issuecomment-690762614
>This PR will cause soft conflicts (which will probably not show up as merge conflicts) with any open PRs that are adding any new Expr, ExprMacro, Function, ApplyFunction, since they will need to include a getOutputType implementation after this PR is merged. I changed my mind and modified this PR to take a less opinionated approach. `Expr.getOutputType` now has a default implementation that will return null for the output type, so this PR should be less disruptive. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
