clintropolis commented on a change in pull request #10370:
URL: https://github.com/apache/druid/pull/10370#discussion_r486762521
##########
File path:
processing/src/main/java/org/apache/druid/query/expression/TimestampCeilExprMacro.java
##########
@@ -93,6 +95,13 @@ public Expr visit(Shuttle shuttle)
return shuttle.visit(new TimestampCeilExpr(newArgs));
}
+ @Nullable
+ @Override
+ public ExprType getOutputType(InputBindingTypes inputTypes)
+ {
+ return ExprType.LONG;
Review comment:
Hmm, so numeric null handling should be done currently be done using
`ExprEval.isNumericNull`, which will return true even if the type is a null
string from a `StringExprEval`. So i think 'string' is technically correct, but
I don't think spiritually or functionally quite true, nor that useful. We
probably should modify these `ExprEval.of(null)` to make type correct
`ExprEval` to make `eval` match exactly what `getOutputType` says, but I don't
know if this PR is the correct place to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
