jihoonson commented on issue #10321: URL: https://github.com/apache/druid/issues/10321#issuecomment-691769526
Sorry @liran-funaro, it took a while to get back to this proposal. The proposed changes sound reasonable to me. Having `AppendableIndexBuilder` in tuningConfig with appendableIndex-specific knobs looks especially useful. However, I'm assuming that those knobs will have default values and users usually don't have to worry about them. Is this right? Regarding `AppendableIndexSpec` interface, do you think it's stable enough or do you perhaps need to make some changes in the near future? If it's the later, `UnstableApi` may be better than making it an `ExtensionPoint` already. > Similar configuration can be added to queries; e.g., to allow alternative indexing methods in group-by queries (such as in `GroupByQueryHelper`) `GroupByQueryHelper` is used in only groupBy v1 which is deprecated in favor of groupBy v2. I'm not sure how much it's slower compared to groupBy v2 or how much using Oak can help with its performance. You may want to look into concurrent processing in groupBy v2 more closely such as `ConcurrentGrouper`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
