Eshcar commented on issue #10321: URL: https://github.com/apache/druid/issues/10321#issuecomment-703596218
Reviewed PR #10335 I suggest to split it into 2 PRs: 1) all refactoring replacing method/class names etc - this incur changing >100 files but has no logical/operational affect 2) the changes that actually add the extension point - this will only change few to dozen files and will make it easier for the reviewer to give feedback Anyway, this change (as one PR or split into 2 PRs) should not affect the normal execution of ingestion/queries; it is only meant to enable future flexibility in supporting external (pluggable) incremental index implementations. I would suggest to adopt it as is. Would appreciate if others in the community can take a look and support the PR @jihoonson @a2l007 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
