clintropolis commented on a change in pull request #10401: URL: https://github.com/apache/druid/pull/10401#discussion_r493096213
########## File path: core/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorProcessor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.math.expr.vector; + +import org.apache.druid.math.expr.Expr; + +/** + * common machinery for processing single input operators and functions, which should always treat null input as null + * output, and are backed by a primitive value instead of an object value (and need to use the null vector instead of + * checking the vector itself for nulls) + */ +public abstract class UnivariateFunctionVectorProcessor<TInput, TOutput> implements ExprVectorProcessor<TOutput> +{ + final ExprVectorProcessor<TInput> processor; + final int maxVectorSize; + final boolean[] outNulls; + final TOutput outValues; + + public UnivariateFunctionVectorProcessor( + ExprVectorProcessor<TInput> processor, + int maxVectorSize, + TOutput outValues + ) + { + this.processor = processor; + this.maxVectorSize = maxVectorSize; + this.outNulls = new boolean[maxVectorSize]; Review comment: it was easier to just always set it, but yeah this is an area that could probably be optimized a bit since we could ignore it totally for default mode I guess. I sort of dream of a world where default mode value coercion madness only lives at the borders and doesn't exist in expressions though... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
