clintropolis commented on a change in pull request #10401: URL: https://github.com/apache/druid/pull/10401#discussion_r493096475
########## File path: core/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorProcessor.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.math.expr.vector; + +import org.apache.druid.math.expr.Expr; + +/** + * common machinery for processing two input operators and functions, which should always treat null inputs as null + * output, and are backed by a primitive values instead of an object values (and need to use the null vectors instead of + * checking the vector themselves for nulls) + */ +public abstract class BivariateFunctionVectorProcessor<TLeftInput, TRightInput, TOutput> + implements ExprVectorProcessor<TOutput> +{ + final ExprVectorProcessor<TLeftInput> left; + final ExprVectorProcessor<TRightInput> right; + final int maxVectorSize; + final boolean[] outNulls; + final TOutput outValues; + + protected BivariateFunctionVectorProcessor( + ExprVectorProcessor<TLeftInput> left, + ExprVectorProcessor<TRightInput> right, + int maxVectorSize, + TOutput outValues + ) + { + this.left = left; + this.right = right; + this.maxVectorSize = maxVectorSize; + this.outNulls = new boolean[maxVectorSize]; Review comment: Like i said in the other comment i just did this way because was slightly easier, it is worth revisiting this in follow-up work ########## File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/VirtualColumnRegistry.java ########## @@ -136,9 +137,11 @@ public RowSignature getFullRowSignature() final RowSignature.Builder builder = RowSignature.builder().addAll(baseRowSignature); + ColumnInspector baseRowsInspector = builder.build().asColumnInspector(); Review comment: yeah, but this was true before. It would be possible to examine the expressions and resolve an execution order probably to allow it, but we haven't built it yet. This code would need to change to match I think ########## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ########## @@ -148,6 +171,47 @@ default ExprType getOutputType(InputBindingTypes inputTypes) { @Nullable ExprType getType(String name); + + default boolean areNumeric(List<Expr> args) + { + boolean numeric = args.size() > 0; Review comment: there was nothing to compute an output type from, im not sure if nothing counts as numeric. added javadocs to explain this and other methods ########## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ########## @@ -49,6 +51,16 @@ */ String name(); + default boolean canVectorize(Expr.InputBindingTypes inputTypes, Expr lambda, List<Expr> args) + { + return false; + } + + default <T> ExprVectorProcessor<T> asVectorProcessor(Expr.VectorInputBindingTypes inputTypes, Expr lambda, List<Expr> args) Review comment: added ########## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ########## @@ -49,6 +51,16 @@ */ String name(); + default boolean canVectorize(Expr.InputBindingTypes inputTypes, Expr lambda, List<Expr> args) + { + return false; + } + + default <T> VectorExprProcessor<T> asVectorProcessor(Expr.VectorInputBindingTypes inputTypes, Expr lambda, List<Expr> args) Review comment: added ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
