ccaominh commented on pull request #10408:
URL: https://github.com/apache/druid/pull/10408#issuecomment-697820571
> > > This PR currently breaks the existing configuration route.
> > > Try adding `"customHeaders": { 'x-test-header': 'this-is-a-test' }` to
the console-config.js file and see that the custom headers will not be applied.
This is because while you are creating a custom instance you are still setting
`Api.defaults` which will not be read now.
> > > I suggest you make a method called `Api.initialize` that will take the
configs and create the instance. It must be called before any API requests can
go through (in `entry.ts`).
> >
> >
> > Is it possible to add a test so that CI can help ensure this doesn't
break in the future?
>
> @ccaominh maybe we can re-run the failed travis-cI test case. Please let
me know how I can get it fixed.
I've retriggered ` (Compile=openjdk8, Run=openjdk8) compaction integration
test ` since the failure doesn't look related to this PR.
I think it'd be useful to add a web console test that ensures that the
custom header, etc. are preserved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
