vogievetsky commented on a change in pull request #10408:
URL: https://github.com/apache/druid/pull/10408#discussion_r502988225
##########
File path: web-console/src/views/datasource-view/datasource-view.tsx
##########
@@ -425,7 +425,7 @@ GROUP BY 1`;
return (
<AsyncActionDialog
action={async () => {
- const resp = await axios.delete(
+ const resp = await Api.delete(
`/druid/coordinator/v1/datasources/${datasourceToMarkAsUnusedAllSegmentsIn}`,
Review comment:
In the theme of listing all the API endpoints in once file, I think this
one could be extracted also for consistency. Maybe extract it as
`/druid/coordinator/v1/datasources/%s` and then do a `.replace('%s',
datasourceToMarkAsUnusedAllSegmentsIn)` in this function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
