viongpanzi commented on a change in pull request #10362:
URL: https://github.com/apache/druid/pull/10362#discussion_r494076383
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java
##########
@@ -302,8 +302,12 @@ private void actionCompleted(SegmentHolder segmentHolder)
{
switch (segmentHolder.getType()) {
case LOAD:
- segmentsToLoad.remove(segmentHolder.getSegment());
- queuedSize.addAndGet(-segmentHolder.getSegmentSize());
+ // When load failed a segment will be removed from the segmentsToLoad
twice and
+ // null value will be returned at the second time in which case
queueSize may be negitive.
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
