vogievetsky opened a new pull request #10454:
URL: https://github.com/apache/druid/pull/10454


   There was a styling regression in the web console that made the tick in the 
checkbox box not render.
   
   
![image](https://user-images.githubusercontent.com/177816/94633641-d22b7700-0282-11eb-8233-3b8cf2c2ca78.png)
   
   This is what it looked like in previously:
   
   
![image](https://user-images.githubusercontent.com/177816/94633677-f25b3600-0282-11eb-8424-49d29c57a468.png)
   
   After looking into it I decided to switch away from using blueprint's 
`Checkbox` control.
   
   For lists (like the one above) a more blueprint idiomatic way is to set an 
icon on a `MenuItem` this way does not require any css hacks.
   
   This is how it looks:
   
   
![image](https://user-images.githubusercontent.com/177816/94634249-634f1d80-0284-11eb-9c00-059d538c83c7.png)
   
   
![image](https://user-images.githubusercontent.com/177816/94634292-7feb5580-0284-11eb-9f57-972ad8270c1e.png)
   
   
   For all other places where a Checkbox was used (log tailing in the ShowLogs 
dialog and WarningChecklist) I switched the control to a switch - which I think 
is nicer because it is bigger and more satisfying to use. It is also more 
common throughout the UI.
   
   
![image](https://user-images.githubusercontent.com/177816/94634199-40246e00-0284-11eb-93d4-17b7f4e909ca.png)
   
   
![image](https://user-images.githubusercontent.com/177816/94634226-4fa3b700-0284-11eb-895d-a3434a366a10.png)
   
   I think it is an improvement in all cases.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to