clintropolis opened a new pull request #10460:
URL: https://github.com/apache/druid/pull/10460


   ### Description
   This PR fixes an issue caused by #9638 being a bit over-ambitious and wiring 
up calcite arrays to druid array types, which resulted in array types leaking 
into the rest of the query engine.
   
   It also fixes an bug where expressions with explicitly array typed output 
could incorrectly set `ExpressionPlan.Trait.SINGLE_INPUT_MAPPABLE` resulting in 
an incorrect dimension selector being used.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to