suneet-s commented on a change in pull request #10463:
URL: https://github.com/apache/druid/pull/10463#discussion_r498875012
##########
File path:
integration-tests/src/main/java/org/apache/druid/testing/utils/KafkaEventWriter.java
##########
@@ -42,8 +42,8 @@
public KafkaEventWriter(IntegrationTestingConfig config, boolean txnEnabled)
{
Properties properties = new Properties();
- KafkaUtil.addPropertiesFromTestConfig(config, properties);
properties.setProperty("bootstrap.servers", config.getKafkaHost());
+ KafkaUtil.addPropertiesFromTestConfig(config, properties);
Review comment:
Maybe move this to line 56 so that the config can override other
properties like `acks` if needed in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
