maytasm opened a new pull request #10467:
URL: https://github.com/apache/druid/pull/10467
Fix bug in TimedShutoffInputSourceReader where a timeout does not close all
registered closeable
### Description
When wrappingIterator.close() is called in the shutdown executor (of
TimedShutoffInputSourceReader#decorateShutdownTimeout), the first thing it does
is call exec::shutdownNow. This is because the Closer close closeables in LIFO
order. Thus, the shutdown executor shutdowns itself first before shutting down
the all the other registered closeable, which means that the closing of the
other closeable may be interrupted, and the closing doesn't finish. This leave
the closeable orphaned and running forever.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
