clintropolis commented on a change in pull request #10467:
URL: https://github.com/apache/druid/pull/10467#discussion_r499070127
##########
File path:
core/src/main/java/org/apache/druid/data/input/impl/TimedShutoffInputSourceReader.java
##########
@@ -68,8 +68,11 @@ public TimedShutoffInputSourceReader(InputSourceReader
delegate, DateTime shutof
)
{
final Closer closer = Closer.create();
- closer.register(delegateIterator);
+ // We must register the shutdow of the shutdown executor first. This will
make sure that the shutdow of the
Review comment:
nit: typo 'shutdow' -> 'shutdown'.
Also, if you have to change things anyway, that is a lot of shutdown, how
about replacing the last 2 sentences with something like "This will cause the
executor to be closed last and ensure other resources which might depend on it
can close successfully."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
