liran-funaro opened a new issue #10494:
URL: https://github.com/apache/druid/issues/10494


   ### Motivation
   
   #10335 added a per incremental-index builder, but the parent class builder 
(`IncrementalIndex.Builder`) was not removed to avoid 100+ lines changes in the 
test code.
   
   ### Proposed changes
   
   Remove `IncrementalIndex.Builder` and refactor all its usage (only in tests 
the test code) to be parametrized (test both builder implementations (on-heap 
and off-heap).
   
   ### Rationale
   
   Remove redundant code.
   
   ### Operational impact
   
   This has no implication on the user experience.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to