jihoonson commented on a change in pull request #10383:
URL: https://github.com/apache/druid/pull/10383#discussion_r502079368
##########
File path:
core/src/test/java/org/apache/druid/data/input/impl/JsonInputFormatTest.java
##########
@@ -69,7 +69,7 @@ public void testEquals()
new ObjectMapper(),
new ObjectMapper()
)
- .withIgnoredFields("objectMapper")
+ .withIgnoredFields("objectMapper", "lineSplittable")
Review comment:
Hmm, good point. Yeah, it's not a good convention to include a mutable
field in `equals()` or `hashCode()` because they can be used as a key of a
`HashMap` or `HashSet`. I would like to suggest to make `lineSplittable`
immutable, but add a new method `withLineSplittable(boolean lineSplittable)`
instead of `setLineSplittable()` which creates a new `JsonInputFormat` instance
with the given value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
