clintropolis opened a new pull request #10499: URL: https://github.com/apache/druid/pull/10499
### Description This PR adds support for vectorizing expressions in cases where inputs are missing, using either null or default values as inputs, depending on the value of `druid.generic.useDefaultValueForNull`. This PR also makes non-vectorized expression type handling a bit more consistent across different types of expressions. Major changes here include operator expressions will now try to preserve the type when one of the arguments is null instead of always producing double values, and math functions now follow logic similar to the operators. Tagging PR as release notes/incompatible because the changes cause some expressions to output slightly different results (typically longs instead of doubles). Examples: `longColumn + nonExistentColumn -> longColumn + 0L` instead of `(double) longColumn + 0.0` and math functions will produce output from non-existent inputs in default mode instead of always producing zeros: `max(longColumn, nonExistentColumn) -> max(longColumn, 0L)` <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
