a2l007 commented on a change in pull request #10335:
URL: https://github.com/apache/druid/pull/10335#discussion_r505591694
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskTuningConfig.java
##########
@@ -281,7 +292,8 @@ public boolean equals(Object o)
return false;
}
SeekableStreamIndexTaskTuningConfig that =
(SeekableStreamIndexTaskTuningConfig) o;
- return maxRowsInMemory == that.maxRowsInMemory &&
+ return Objects.equals(appendableIndexSpec, that.appendableIndexSpec) &&
+ maxRowsInMemory == that.maxRowsInMemory &&
Review comment:
Could you please write an EqualsVerifier test for this. That should take
care of the travis failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
