zhangyue19921010 commented on a change in pull request #10555:
URL: https://github.com/apache/druid/pull/10555#discussion_r517228372
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/concurrent/ScheduledExecutors.java
##########
@@ -53,7 +53,11 @@ public static void scheduleWithFixedDelay(
public Signal call()
{
runnable.run(); // (Exceptions are handled for us)
- return Signal.REPEAT;
+ if (exec.isShutdown()) {
+ return Signal.STOP;
Review comment:
Done. By the way it seems that I can't passed the
'continuous-integration/travis-ci/pr'. Because existing test code seems to
never cover ScheduledExecutors which is a util class. Orz...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
