FrankChen021 commented on a change in pull request #10383:
URL: https://github.com/apache/druid/pull/10383#discussion_r520275503
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/overlord/sampler/InputSourceSamplerTest.java
##########
@@ -1060,6 +1062,107 @@ public void testWithFilter() throws IOException
);
}
+ @Test
+ public void testIndexParseException() throws IOException
Review comment:
A block of multiple json strings is only supported in stream ingestion
as we discussed above, that's also why the test cases are added in
kafka-indexing-service module.[It's implemented by setting the new property on
`JsonInputFormat` in
`RecordSupplierInputSource`](https://github.com/apache/druid/pull/10383/files#diff-72b4a411d4ce193935a708df516b00f94827e9563ba7adf00c9e0be479435b5bR106).
For test cases for `InputSourceSampler` here, the input source is
`InlineInputSource` which always uses `InputEntityIteratingReader` even when
input format is `JsonInputFormat`, there's no chance to test that. So I think
we don't need add test cases here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
