FrankChen021 commented on a change in pull request #10383:
URL: https://github.com/apache/druid/pull/10383#discussion_r520347805
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/overlord/sampler/InputSourceSamplerTest.java
##########
@@ -1060,6 +1062,107 @@ public void testWithFilter() throws IOException
);
}
+ @Test
+ public void testIndexParseException() throws IOException
Review comment:
> I think we need such tests because `KafkaIndexTaskTest` only covers
the actual indexing side, but not the sampling side. Without those tests, we
could break the sampler without being noticed.
I forgot that test cases in `KafkaIndexTaskTest` only cover the indexing
process. It's OK for me to add such tests.
BTW, integration tests failed, I don't think it's related to changes in this
PR, and the failure can also be seen in my other PR, is there any other problem
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
