himanshug commented on pull request #10495: URL: https://github.com/apache/druid/pull/10495#issuecomment-731452856
> It will open flood gate and finding things will be needle in a haystack current patch prints all of non-GET requests , so by setting "org.apache.druid.jetty.RequestLog" logger to debug in coordinator/overlord would lead to print all GET requests additionally... I didn't think coordinator/overlord would have so many of those . Have you tried and found an overwhelming number of GETs coming to coordinator/overlord (maybe I am forgetting something that periodically is sending requests to them). all the other problems you mentioned are tooling things, e.g. you would anyways have to manage different configuration for different environments. anyways, current patch appears to introduce work for all processes (broker/mm/historical) where the predicates will ALWAYS be false .. so there needs to be a way to make this optional so that users can opt-in to it rather than always getting it. you could probably introduce a flag in existing code where you can optionally disable the printing of GET requests and that would solve the flood gate problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
