senthilkv opened a new pull request #10495:
URL: https://github.com/apache/druid/pull/10495


   This PR Describes changes applied to the Requestlog.
     
   The Requestlog has been updated to capture state changing api calls such as 
(POST/DELETE/UPDATE), so that this can be used to audit, debugging logs in 
order to identify who, what , when.  The code has been tested on our internal 
clusters. The log generated is presented as follows
   
   xx.xx.xx.xx DELETE 
https://druid-coord.xxxxxx.comm:4443/druid/coordinator/v1/datasources/testdata_A1M_02_01
 HTTP/1.1
   xx.xx.xx.xx POST 
https://druid-coord.xxxxxx.com:4443/druid/coordinator/v1/datasources/testdata_A1M_02_02/markUnused
 HTTP/1.1
   
   If the community feels that it is too much to capture these details , in 
future we can provide updates  to capture in a separate file.
   
   <!-- Thanks for trying to help us make Apache Druid be the best it can be! 
Please fill out as much of the following information as is possible (where 
relevant, and remove it when irrelevant) to help make the intention and scope 
of this PR clear in order to ease review. -->
   
   This enhances RequestLog for audit and debugging.
   
   
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers.
 -->
   
   ### Description
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist above are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * Requestlog


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to