liran-funaro commented on a change in pull request #10593:
URL: https://github.com/apache/druid/pull/10593#discussion_r533158100
##########
File path:
benchmarks/src/test/java/org/apache/druid/benchmark/query/GroupByBenchmark.java
##########
@@ -428,14 +424,12 @@ private void setupQueries()
}
@Setup(Level.Trial)
- public void setup() throws IOException
+ public void setup()
{
log.info("SETUP CALLED AT " + +System.currentTimeMillis());
ComplexMetrics.registerSerde("hyperUnique", new HyperUniquesSerde());
- executorService = Execs.multiThreaded(numProcessingThreads,
"GroupByThreadPool[%d]");
Review comment:
These changes are due to the scoping of the benchmark. This setup method
now only in charge of initializing everything common for benchmarking both the
incremental-index and the queriable-index.
Anything specific to the incremental or queriable index was moved to its
designated scope below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
