liran-funaro commented on a change in pull request #10593:
URL: https://github.com/apache/druid/pull/10593#discussion_r533216995
##########
File path:
processing/src/test/java/org/apache/druid/query/DoubleStorageTest.java
##########
@@ -321,10 +322,10 @@ private static QueryableIndex buildIndex(String
storeDoubleAsFloat) throws IOExc
)
.build();
- final IncrementalIndex index = new IncrementalIndex.Builder()
Review comment:
This is true for tests that do not test the incremental-index
implementation. For such tests, we use the on-heap implementation because it is
the most stable.
Tests that test the index itself, are now parametrized so they have more
modifications other than these 5 lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
