jihoonson commented on a change in pull request #10631:
URL: https://github.com/apache/druid/pull/10631#discussion_r535850965
##########
File path: integration-tests/docker/environment-configs/coordinator
##########
@@ -32,7 +32,11 @@ druid_coordinator_startDelay=PT5S
druid_manager_lookups_hostUpdateTimeout=PT30S
druid_manager_lookups_period=10000
druid_manager_lookups_threadPoolSize=2
+druid_manager_config_pollDuration=PT10S
+druid_manager_rules_pollDuration=PT10S
+druid_manager_segments_pollDuration=PT2S
druid_auth_basic_common_cacheDirectory=/tmp/authCache/coordinator
druid_auth_unsecuredPaths=["/druid/coordinator/v1/loadqueue"]
druid_server_https_crlPath=/tls/revocations.crl
-druid_coordinator_period_indexingPeriod=PT180000S
\ No newline at end of file
+druid_coordinator_period_indexingPeriod=PT180000S
+druid_coordinator_period=PT1S
Review comment:
Is this too aggressive? :sweat_smile:
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java
##########
@@ -160,8 +160,11 @@ default int getPriority()
/**
* Execute preflight actions for a task. This can be used to acquire locks,
check preconditions, and so on. The
* actions must be idempotent, since this method may be executed multiple
times. This typically runs on the
- * coordinator. If this method throws an exception, the task should be
considered a failure.
- * <p/>
+ * Overlord. If this method throws an exception, the task should be
considered a failure.
+ *
+ * This method will not necessarily be executed before {@link
#run(TaskToolbox)}, since this task readiness check
+ * may be done on a different machine from the one that actually runs the
task.
Review comment:
Hmm, how can this happen? I thought `Task.isReady()` is always called
before `Task.run()` because a task can be scheduled only when `Task.isReady()`
returns true. `Task.run()` will be called after the task is scheduled in some
indexer or middleManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
