jihoonson commented on a change in pull request #10631:
URL: https://github.com/apache/druid/pull/10631#discussion_r535866173
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java
##########
@@ -160,8 +160,11 @@ default int getPriority()
/**
* Execute preflight actions for a task. This can be used to acquire locks,
check preconditions, and so on. The
* actions must be idempotent, since this method may be executed multiple
times. This typically runs on the
- * coordinator. If this method throws an exception, the task should be
considered a failure.
- * <p/>
+ * Overlord. If this method throws an exception, the task should be
considered a failure.
+ *
+ * This method will not necessarily be executed before {@link
#run(TaskToolbox)}, since this task readiness check
+ * may be done on a different machine from the one that actually runs the
task.
Review comment:
Oh, I see. I think it happens only in indexers because peon calls
`isReady()` before it runs its task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
