FrankChen021 commented on a change in pull request #10635:
URL: https://github.com/apache/druid/pull/10635#discussion_r537244165
##########
File path:
core/src/test/java/org/apache/druid/java/util/common/HumanReadableBytesTest.java
##########
@@ -395,6 +395,107 @@ public void testBytesRange()
Assert.assertEquals("value must be in the range of [0, 5]", message);
}
+ @Test
+ public void testFormatInBinaryByte()
+ {
+ Assert.assertEquals("-8.00 EiB", HumanReadableBytes.format(Long.MIN_VALUE,
2, HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("-8.000 EiB",
HumanReadableBytes.format(Long.MIN_VALUE, 3,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+
+ Assert.assertEquals("-2.00 GiB",
HumanReadableBytes.format(Integer.MIN_VALUE, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("-32.00 KiB",
HumanReadableBytes.format(Short.MIN_VALUE, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("-128.00 B", HumanReadableBytes.format(Byte.MIN_VALUE,
2, HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("-1.00 B", HumanReadableBytes.format(-1, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("0.00 B", HumanReadableBytes.format(0, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.00 B", HumanReadableBytes.format(1, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.00 KiB", HumanReadableBytes.format(1024L, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.00 MiB", HumanReadableBytes.format(1024L * 1024, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.00 GiB", HumanReadableBytes.format(1024L * 1024 *
1024, 2, HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.00 TiB", HumanReadableBytes.format(1024L * 1024 *
1024 * 1024, 2, HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.00 PiB", HumanReadableBytes.format(1024L * 1024 *
1024 * 1024 * 1024, 2, HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("8.00 EiB", HumanReadableBytes.format(Long.MAX_VALUE,
2, HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ }
+
+ @Test
+ public void testPrecisionInBinaryFormat()
+ {
+ Assert.assertEquals("1 KiB", HumanReadableBytes.format(1500, 0,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.5 KiB", HumanReadableBytes.format(1500, 1,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.46 KiB", HumanReadableBytes.format(1500, 2,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ Assert.assertEquals("1.465 KiB", HumanReadableBytes.format(1500, 3,
HumanReadableBytes.UnitSystem.BINARY_BYTE, true));
+ }
+
+ @Test
+ public void testPrecisionInDecimalFormat()
+ {
+ Assert.assertEquals("1 KB", HumanReadableBytes.format(1456, 0,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.5 KB", HumanReadableBytes.format(1456, 1,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.46 KB", HumanReadableBytes.format(1456, 2,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.456 KB", HumanReadableBytes.format(1456, 3,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ }
+
+ @Test
+ public void testFormatInDecimalByte()
+ {
+ Assert.assertEquals("1.00 B", HumanReadableBytes.format(1, 2,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.00 KB", HumanReadableBytes.format(1000L, 2,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.00 MB", HumanReadableBytes.format(1000L * 1000, 2,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.00 GB", HumanReadableBytes.format(1000L * 1000 *
1000, 2, HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.00 TB", HumanReadableBytes.format(1000L * 1000 *
1000 * 1000, 2, HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("1.00 PB", HumanReadableBytes.format(1000L * 1000 *
1000 * 1000 * 1000, 2, HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("9.22 EB", HumanReadableBytes.format(Long.MAX_VALUE,
2, HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+
+ Assert.assertEquals("100.00 KB", HumanReadableBytes.format(99999, 2,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("99.999 KB", HumanReadableBytes.format(99999, 3,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+
+ Assert.assertEquals("999.9 PB",
HumanReadableBytes.format(999_949_999_999_999_999L, 1,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("999.95 PB",
HumanReadableBytes.format(999_949_999_999_999_999L, 2,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ Assert.assertEquals("999.949 PB",
HumanReadableBytes.format(999_949_999_999_999_999L, 3,
HumanReadableBytes.UnitSystem.DECIMAL_BYTE, true));
+ }
+
+ @Test
+ public void testFormatInDecimal()
+ {
+ Assert.assertEquals("1.00 ", HumanReadableBytes.format(1, 2,
HumanReadableBytes.UnitSystem.DECIMAL, true));
Review comment:
This special case has been handled in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
