gianm commented on a change in pull request #10660:
URL: https://github.com/apache/druid/pull/10660#discussion_r539587314
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -270,8 +270,15 @@ public void start() throws InterruptedException
// Add missing segments back to the refresh list.
segmentsNeedingRefresh.addAll(Sets.difference(segmentsToRefresh, refreshed));
+ // remove any tables which have been completely dropped
before refresh
Review comment:
This looks like it's undoing a mistake in removeSegment — the datasource
should never have been added to dataSourcesNeedingRebuild in the first place.
IMO it'd be better to make the change there. Doing it here works, though, so
I'm OK with it if you don't want to move the logic around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
