clintropolis commented on a change in pull request #10660:
URL: https://github.com/apache/druid/pull/10660#discussion_r539987326
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -270,8 +270,15 @@ public void start() throws InterruptedException
// Add missing segments back to the refresh list.
segmentsNeedingRefresh.addAll(Sets.difference(segmentsToRefresh, refreshed));
+ // remove any tables which have been completely dropped
before refresh
Review comment:
Looks like one of the integration tests failed after the latest
modifications, so more than just moving `dataSourcesNeedingRebuild.add` to the
else is needed. I suspect it is the `removeServerSegment` which should also
probably check if there are any segments before adding to the list in case it
is triggered by the broker (broker segments are not currently tracked in
`segmentMetadataInfo` since they will always currently be duplicated on a
historical)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
