clintropolis commented on a change in pull request #10680:
URL: https://github.com/apache/druid/pull/10680#discussion_r543145989
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -586,7 +638,8 @@ public TableType getJdbcTableType()
StringUtils.toLowerCase(discoveryDruidNode.getNodeRole().toString()),
druidServerToUse.getTier(),
currentSize,
- druidServerToUse.getMaxSize()
+ druidServerToUse.getMaxSize(),
+ NullHandling.defaultLongValue()
Review comment:
ideally it should always be null because they don't have the concept of
leadership at all and then you can distinguish between things which are leader,
are not leader, and which don't have leaders. `NullHandling.defaultLongValue()`
is null when `druid.generic.useDefaultValueForNull=false`, but in default mode
numbers cannot be null so it is 0 there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
