jihoonson commented on a change in pull request #10680:
URL: https://github.com/apache/druid/pull/10680#discussion_r543778952



##########
File path: 
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -159,6 +160,7 @@
       .add("tier", ValueType.STRING)
       .add("curr_size", ValueType.LONG)
       .add("max_size", ValueType.LONG)
+      .add("is_leader", ValueType.LONG)

Review comment:
       I guess it's to be consistent with other boolean types such as 
`is_published` in the segments table. It is useful for those boolean columns in 
the segments table to be long so that we can easily compute sums of them. For 
this column, I think it doesn't have to be long, but I don't mind either.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to