suneet-s commented on a change in pull request #10682:
URL: https://github.com/apache/druid/pull/10682#discussion_r543780077
##########
File path: web-console/src/entry.ts
##########
@@ -73,7 +73,7 @@ if (consoleConfig.baseURL) {
UrlBaser.baseUrl = consoleConfig.baseURL;
}
if (consoleConfig.customHeaderName && consoleConfig.customHeaderValue) {
- apiConfig.headers.common[consoleConfig.customHeaderName] =
consoleConfig.customHeaderValue;
+ apiConfig.headers[consoleConfig.customHeaderName] =
consoleConfig.customHeaderValue;
Review comment:
https://github.com/apache/druid/pull/10597/files#diff-5563ae2b9ba7d6595882c5bae584d1b9db3db64c0257d8d661ccd98e6a6029f0L77
It looks like `.common` was a copy over from this PR
I don't understand the web console enough to comment on this change. Can you
explain what broke/ what tests we need to prevent this from breaking in the
future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
