vogievetsky commented on a change in pull request #10682:
URL: https://github.com/apache/druid/pull/10682#discussion_r543783563
##########
File path: web-console/src/entry.ts
##########
@@ -73,7 +73,7 @@ if (consoleConfig.baseURL) {
UrlBaser.baseUrl = consoleConfig.baseURL;
}
if (consoleConfig.customHeaderName && consoleConfig.customHeaderValue) {
- apiConfig.headers.common[consoleConfig.customHeaderName] =
consoleConfig.customHeaderValue;
+ apiConfig.headers[consoleConfig.customHeaderName] =
consoleConfig.customHeaderValue;
Review comment:
I think the default axios config has `.common` key on headers (meaning
headers that should be used for all requests).
https://github.com/axios/axios#global-axios-defaults but the new defaults did
not. I think we can set all these `consoleConfig` configs as part of the e2e
tests to make sure nothing breaks as a result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
