a2l007 commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-746688428
> > * `IndexPersistBenchmark`: this benchmark previously cleaned the temporary data folder inside the tested method, instead of in the teardown procedure. For large index sizes, it affected the benchmark result significantly. > With this modification, the results will be different (shorter times), but it will better reflect the "persist" performance. > > * `IncrementalIndexRowTypeBenchmark`: before the number of rows was not parametrized and it reported the time per single row insertion. Now it reports the total insertion time of all the rows, like the rest of the tests report. There is no option in JMH to set the `@OperationsPerInvocation(MAX_ROWS)` with respect to the parameter `rowsPerSegment`. > > * `ScanBenchmark`, `SearchBenchmark`: now using a fixed seed, so the results are reproducible but might be different than what was before with the random seed. I feel that this should be called out in the release notes so that users running benchmarks are aware of this change before upgrading. Could you please add a short description in the PR description mentioning the changes a user should expect running benchmarks before upgrading to this version. This would help the release manager add the blurb to the release notes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
