a2l007 commented on a change in pull request #10593:
URL: https://github.com/apache/druid/pull/10593#discussion_r543642524
##########
File path:
benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IncrementalIndexReadBenchmark.java
##########
@@ -110,28 +119,28 @@ public void setup() throws IOException
);
incIndex = makeIncIndex();
+ gen.addToIndex(incIndex, rowsPerSegment);
Review comment:
Changing it in a follow-up PR sounds good to me.
##########
File path:
benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IndexPersistBenchmark.java
##########
@@ -87,101 +90,95 @@
@Param({"true", "false"})
private boolean rollup;
- @Param({"none", "moderate", "high"})
- private String rollupOpportunity;
+ @Param({"0", "1000", "10000"})
+ private int rollupOpportunity;
Review comment:
Sorry I missed this earlier, but I feel that we should retain the
textual values for rollupOpportunity as that is more user-friendly when reading
the benchmark results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
