loquisgon commented on a change in pull request #10685:
URL: https://github.com/apache/druid/pull/10685#discussion_r547588695
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedBufferHashGrouper.java
##########
@@ -318,6 +336,8 @@ public void close()
private CloseableIterator<Entry<KeyType>> makeHeapIterator()
{
final int initialHeapSize = offsetHeap.getHeapSize();
+ ByteBufferMinMaxOffsetHeap newHeap = offsetHeap.copy();
Review comment:
Done in next commit
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java
##########
@@ -59,6 +59,32 @@ public ByteBufferMinMaxOffsetHeap(
this.heapIndexUpdater = heapIndexUpdater;
}
+ public ByteBufferMinMaxOffsetHeap copy()
Review comment:
Done in next commit
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedBufferHashGrouper.java
##########
@@ -318,6 +336,8 @@ public void close()
private CloseableIterator<Entry<KeyType>> makeHeapIterator()
Review comment:
Done in next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
