capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r552240383
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -1058,7 +1058,8 @@ private synchronized void persistSequences() throws
IOException
ingestionState,
getTaskCompletionUnparseableEvents(),
getTaskCompletionRowStats(),
- errorMsg
+ errorMsg,
+ false
Review comment:
I went with `errorMsg == null` and added a javadoc stating the errorMsg
String should be null on success and non-null on failure. Current code follows
that pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
