capistrant commented on a change in pull request #10676:
URL: https://github.com/apache/druid/pull/10676#discussion_r556922336
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
##########
@@ -584,7 +584,8 @@ protected boolean
isFirehoseDrainableByClosing(FirehoseFactory firehoseFactory)
ingestionState,
getTaskCompletionUnparseableEvents(),
getTaskCompletionRowStats(),
- errorMsg
+ errorMsg,
+ false
Review comment:
I think this should be errorMsg == null. also add javadoc
```
/**
* Return a map of reports for the task.
*
* A successfull task should always have a null errorMsg. A falied task
should always have a non-null
* errorMsg. Nullable error message for the task. null if task succeeded.
*
* @return Map of reports for the task.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
