gianm commented on a change in pull request #10732:
URL: https://github.com/apache/druid/pull/10732#discussion_r556053575
##########
File path:
server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java
##########
@@ -28,9 +29,17 @@
*/
public class DruidMonitorSchedulerConfig extends MonitorSchedulerConfig
{
+ @JsonProperty
+ private String schedulerClassName =
ClockDriftSafeMonitorScheduler.class.getName();
Review comment:
My 2ยข: the best plan is to default to the old one, and then in the
future (after some people have enabled the new one in production) we should
switch to the new one, and remove the old one and remove the config entirely.
Rationale:
The new scheduler is designed to eliminate potential clock drift for
monitors. This reward is real but is pretty small impact. I don't expect
anything bad will happen if the schedule drifts a bit. The main risk of the new
scheduler, I suppose, is that there's some case where it goes haywire, and
either locks up completely or fires much more often than it should. I'm not
sure how likely this is, but it's (a) hard to test for, (b) quite bad if it
happens.
So, because the potential reward has a small impact, and the potential risk
has a large impact, I think it's best to default to the old scheduler for
another release or so. Just until such time as people have been able to do
long-running tests in production and have found that there are no issues.
At any rate, it's good that this is undocumented, since it's an
inside-baseball sort of config that we would only want to exist for a few
releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
