jihoonson commented on a change in pull request #10732:
URL: https://github.com/apache/druid/pull/10732#discussion_r556211566
##########
File path:
server/src/main/java/org/apache/druid/server/metrics/DruidMonitorSchedulerConfig.java
##########
@@ -28,9 +29,17 @@
*/
public class DruidMonitorSchedulerConfig extends MonitorSchedulerConfig
{
+ @JsonProperty
+ private String schedulerClassName =
ClockDriftSafeMonitorScheduler.class.getName();
Review comment:
> So, because the potential reward has a small impact, and the potential
risk has a large impact, I think it's best to default to the old scheduler for
another release or so. Just until such time as people have been able to do
long-running tests in production and have found that there are no issues.
This makes sense to me. I think we can do more extensive testing by
ourselves instead of rushing to change the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
